Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport boost 3.4.6 Changes #38057

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Backport boost 3.4.6 Changes #38057

merged 2 commits into from
Jun 26, 2024

Conversation

dilirity
Copy link
Member

Proposed changes:

Backports changes for boost 3.4.6

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/a

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Proofread changes.

@dilirity dilirity added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jun 26, 2024
Copy link
Contributor

github-actions bot commented Jun 26, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the prerelease branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack prerelease
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@dilirity dilirity self-assigned this Jun 26, 2024
@github-actions github-actions bot added [Package] My Jetpack [Plugin] Boost A feature to speed up the site and improve performance. Docs labels Jun 26, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Boost plugin:

  • Next scheduled release: July 2, 2024.
  • Scheduled code freeze: June 24, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@dilirity dilirity requested a review from a team June 26, 2024 08:54
@dilirity dilirity enabled auto-merge (squash) June 26, 2024 09:01
Copy link
Contributor

@donnchawp donnchawp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dilirity dilirity disabled auto-merge June 26, 2024 09:06
@dilirity dilirity merged commit a521580 into trunk Jun 26, 2024
75 checks passed
@dilirity dilirity deleted the prerelease branch June 26, 2024 09:15
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs [Package] My Jetpack [Plugin] Boost A feature to speed up the site and improve performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants