-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable loading of Custom CSS for atomic sites in jetpack-mu-wpcom
#38118
Disable loading of Custom CSS for atomic sites in jetpack-mu-wpcom
#38118
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See conversation linked below for more details.
TL;DR or for any non-Automatticians who wind up here: Jetpack gets updated weekly on WoA sites, while wpcomsh generally gets updated more often. With a version of wpcomsh containing #37794 and a version of Jetpack from earlier this week not containing #37794, wpcomsh loads first, defines the function, and there isn't yet the guard in Jetpack against redefining it. 💥
This PR removes the call in wpcomsh that loads all the code added in #37794, so wpcomsh doesn't define the functions. We'll revert this next week after Jetpack gets updated on WoA sites.
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
) * Adding back the changes removed in #38118. * changelog. * Project versions.
Proposed changes:
#37794 caused the wpcomsh plugin to throw the exception:
PHP Fatal error: Cannot redeclare jetpack_register_css_preprocessors()
.This PR prevents the exception from being thrown by temporarily disabling the loading of the Custom CSS for atomic sites in the
jetpack-mu-wpcom
package (the Custom CSS will still be available in the Jetpack plugin for now). See conversation linked below for more details.Other information:
Jetpack product discussion
p1719591775246119-slack-C05PV073SG3
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
/wp-admin/admin.php?page=jetpack_modules
, activate the Custom CSS module