-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help Center: extend post fetch endpoint #38445
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. |
I tested this in Simple and Atomic environments and everything seems to be A-OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reflects the changes made to the endpoint 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on atomic site and was able to retrieve the article related info via post_url + blog_id and post_url.
Proposed changes:
Adds the
post_url
arg tohelp-center/fetch-post
endpoint.This is part of a larger task to allow support guide links in Help Center open within Help Center.
PR for the main package ⇢ Automattic/wp-calypso#92745
PR for the main endpoint ⇢ D155970-code
Other information:
Does this pull request change what data or activity we track or use?
Nope
Testing instructions:
This does not add any feature to test so really we are only testing to make sure the endpoint works and that Help Center does not break.
/fetch-post
fetch
post_id
andblog_id
withpost_url
and the url of an article.