Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MU WPCOM: Stop loading wpcom block editor nux feature #38802

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented Aug 9, 2024

Fixes the regression that has been escalated in p1723186454644719-slack-C02FMH4G8
Reverts #38674

Proposed changes:

Apparently, the automattic/wpcom-welcome-guide store is not available when the Gutenberg plugin is disabled and that causes a failure to the starter-page-templates feature.

It looks like a regression introduced after moving the wpcom block editor nux feature from ETK to jetpack-mu-wpcom (#38674), so as a temporary solution this PR stops loading the feature from jetpack-mu-wpcom.

Before After
Screenshot 2024-08-09 at 14 00 37 Screenshot 2024-08-09 at 13 55 36

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Apply these changes to your WoA dev site
  • Disable the Gutenberg plugin
  • Go to /wp-admin/post-new.php?post_type=page
  • Make sure the "Add a page" modal shows up successfully

@github-actions github-actions bot added the [Package] Jetpack mu wpcom WordPress.com Features label Aug 9, 2024
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Aug 9, 2024
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/pagte-patterns-error branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/pagte-patterns-error
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@mmtr mmtr requested review from a team August 9, 2024 12:04
@arthur791004
Copy link
Contributor

We have to comment the following one to enable the feature from ETK

define( 'MU_WPCOM_BLOCK_EDITOR_NUX', true );

@mmtr mmtr self-assigned this Aug 9, 2024
@mmtr mmtr removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Aug 9, 2024
@mmtr mmtr enabled auto-merge (squash) August 9, 2024 12:17
Copy link
Contributor

@BogdanUngureanu BogdanUngureanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well on Simple and AT.

@mmtr mmtr merged commit 73a2358 into trunk Aug 9, 2024
55 checks passed
@mmtr mmtr deleted the fix/pagte-patterns-error branch August 9, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Jetpack mu wpcom WordPress.com Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants