-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LaunchpadSaveModal: Update action href based on experiment variation #39237
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
864aeb4
to
636a5aa
Compare
Introducing the @types/node in a browser-based package does not seem like a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected, thanks for working on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this PR look OK to me based on inspection.
projects/plugins/jetpack/extensions/plugins/launchpad-save-modal/index.js
Show resolved
Hide resolved
…39237) * Get the experiment variant name * Add missing dependency * Add testing logic * Update primary action href based on the experiment name * Introduce session storage item supporting experiment testing * Add node process type declaration * Add changelog * Rename the session item name
Proposed changes:
The
LaunchpadSaveModal
component has hardcoded redirection to the fullscreen Launchpad onboarding step. With this change, we dynamically decide the redirection href based on the experiment or session storage item information.The default behavior will remain the same if the experiment has not started.
Related Pull Request: Automattic/wp-calypso#93205
Other information:
Jetpack product discussion
Related document: pbxNRc-3Yh-p2
Does this pull request change what data or activity we track or use?
No
Testing instructions:
{SITE_SLUG}/wp-admin/site-editor.php?calypso_origin=http%3A%2F%2Fcalypso.localhost%3A3000&canvas=edit&assembler=1&showLaunchpad=true
window.sessionStorage.setItem( 'launchpad_removal_2024_experiment_variation', 'treatment' );
https://jetpack.com/redirect/?source=calypso-home&site=launchpadtesting1.wordpress.com