Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a CI job for WPCloud testing of wpcomsh. #39258
Added a CI job for WPCloud testing of wpcomsh. #39258
Changes from 2 commits
3a57a51
2ab2c4a
0d40db9
a8da4b4
a3a5533
8b74cdf
4df8ed7
b102738
27bbd07
aad27e3
9e892e4
dfb7439
bf302d5
8f1f194
df0ed81
3618211
510482f
747555d
cdff320
a60df09
4f4f451
f2ff12f
333469a
7de6b72
3ff1bea
131ac21
6b04ffa
738ee0b
e1dbc3e
88dc9a6
6189efa
b9de362
a6b8715
805d152
e482ee5
975ccf2
8b93c18
ca16342
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could switch to a key with no password, so we could skip this. Is there an attack scenario where someone could steal the key but not also steal this file with the password?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(this along with the comment on lines 61–67 above)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm left wondering what's in
WPCLOUD_SSH_COMMAND
that we can't just put it in here.Is whatever this runs going to work if multiple PRs run this at the same time?