Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: change default imploding to false #39486

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Sep 22, 2024

Initial work re p1HpG7-uqh-p2#comment-74006

Proposed changes:

  • The large CSS file is not as effective as it once was, so this changes the default behavior to not enqueue the large file instead of individual CSS files.
  • At this stage, the existing functionality is still included if add_filter( 'jetpack_implode_frontend_css', '__return_true' );

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1HpG7-uqh-p2#comment-74006

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Before patch, enable a few modules from this list: 'carousel', 'contact-form', 'infinite-scroll', 'likes', 'related-posts', 'sharedaddy', 'shortcodes', 'subscriptions', 'tiled-gallery', 'widgets',
  • Ensuring SCRIPT_DEBUG is not enabled, visit the frontend and check the sources for jetpack.css (the imploded file)
  • With this patch, repeat and confirm there is not a jetpack.css file, but are CSS for the modules you enabled.
  • With this patch, add add_filter( 'jetpack_implode_frontend_css', '__return_true' ); to your site and repeat. You should see the jetpack.css file included again.

Copy link
Contributor

github-actions bot commented Sep 22, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the remove/imploding-css branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack remove/imploding-css
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Sep 22, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for October 1, 2024 (scheduled code freeze on September 30, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Contributor

@sergeymitr sergeymitr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sergeymitr sergeymitr added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Team Review labels Sep 23, 2024
@kraftbj kraftbj merged commit 5e2ab4c into trunk Sep 23, 2024
61 checks passed
@kraftbj kraftbj deleted the remove/imploding-css branch September 23, 2024 22:04
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Sep 23, 2024
@github-actions github-actions bot added this to the jetpack/13.9 milestone Sep 23, 2024
gogdzl pushed a commit that referenced this pull request Oct 25, 2024
* Performance: change default imploding to false

* Add phpcs ignores and comment out the previous false declarations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Performance [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants