Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPress: use "Processing" thumbnail placeholder while a new thumbnail is being saved #39631

Merged
merged 4 commits into from
Oct 7, 2024
Merged

VideoPress: use "Processing" thumbnail placeholder while a new thumbnail is being saved #39631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a377a14
Export the thumb update status on the edit details hook
lhkowalski Oct 2, 2024
83f3add
Use poster updating status to set video thumb as processing
lhkowalski Oct 2, 2024
794d324
Changelog
lhkowalski Oct 2, 2024
9b4eb75
Merge remote-tracking branch 'origin/trunk' into update/videopress-up…
dhasilva Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...s/packages/videopress/changelog/update-videopress-update-thumb-placeholder-while-updating
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

VideoPress: fix thumbnail update bug that showed the old thumbnail for a couple seconds on the details page.
3 changes: 2 additions & 1 deletion projects/packages/videopress/src/client/admin/components/edit-video-details/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ const EditVideoDetails = () => {
selectPosterImageFromLibrary,
posterImageSource,
libraryAttachment,
isUpdatingPoster,
} = useEditDetails();

const { canPerformAction } = usePermission();
Expand Down Expand Up @@ -312,7 +313,7 @@ const EditVideoDetails = () => {
<VideoThumbnail
thumbnail={ thumbnail }
loading={ isFetchingData }
processing={ processing }
processing={ processing || isUpdatingPoster }
deleting={ isDeleting }
updating={ updating }
duration={ duration }
Expand Down
2 changes: 2 additions & 0 deletions ...ts/packages/videopress/src/client/admin/components/edit-video-details/use-edit-details.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ export default () => {
processing,
isDeleting,
updateVideoPrivacy,
isUpdatingPoster,
} = useVideo( Number( videoId ), true );

const { playbackToken, isFetchingPlaybackToken } = usePlaybackToken( video );
Expand Down Expand Up @@ -331,5 +332,6 @@ export default () => {
selectedTime,
...metaEditData,
...posterEditData,
isUpdatingPoster,
};
};
Loading