Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Initial code to process coverage data #40016

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Nov 2, 2024

Proposed changes:

To be able to inform the author about the coverage on their PR, we'll need to extract a summary of coverage changes from the raw data we're collecting. This is a first step towards that, combining the raw coverage data into combined files and producing a summary of covered lines in each file.

Also, since it annoyed me, I added WordPress.WP.GlobalVariablesOverride to our Jetpack-NoWP ruleset so non-WordPress code doesn't get useless complaints about common variable names like $path.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • CI happy?
  • Check the artifact. Data look good?

To be able to inform the author about the coverage on their PR, we'll
need to extract a summary of coverage changes from the raw data we're
collecting. This is a first step towards that, combining the raw
coverage data into combined files and producing a summary of covered
lines in each file.

Also, since it annoyed me, I added `WordPress.WP.GlobalVariablesOverride`
to our `Jetpack-NoWP` ruleset so non-WordPress code doesn't get
useless complaints about common variable names like `$path`.
@anomiex anomiex added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] Normal labels Nov 2, 2024
@anomiex anomiex requested a review from a team November 2, 2024 18:51
@anomiex anomiex self-assigned this Nov 2, 2024
Copy link
Contributor

github-actions bot commented Nov 2, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/coverage-processing branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/coverage-processing
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/coverage-processing
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Package] Codesniffer [Tools] Development CLI The tools/cli to assist during JP development. Actions GitHub actions used to automate some of the work around releases and repository management Docker labels Nov 2, 2024
Copy link
Contributor

github-actions bot commented Nov 2, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Boost plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added [Plugin] Boost A feature to speed up the site and improve performance. [Tests] Includes Tests labels Nov 2, 2024
Copy link
Contributor

@tbradsha tbradsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Artifacts look good and no errors in CI (other than an unrelated one I address in #40042).

@anomiex anomiex merged commit ce35f15 into trunk Nov 5, 2024
75 checks passed
@anomiex anomiex deleted the add/coverage-processing branch November 5, 2024 21:51
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions GitHub actions used to automate some of the work around releases and repository management Docker [Package] Codesniffer [Plugin] Boost A feature to speed up the site and improve performance. [Pri] Normal [Tests] Includes Tests [Tools] Development CLI The tools/cli to assist during JP development. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants