-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack AI: Add thumbs up/down component to AI logo generator #40610
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
9fe000c
to
1950287
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Mostly" works. Implementation is good, thanks for moving the files to the ai-client package.
Feedback works, they send out the events and the logos change color to reflect the feedback sent. However, if you navigate to another logo and go back to one you've sent feedback already, the feedback is not reflected. Reloading, hence loading again from localStorage, fixes it. The rated feedback is stored on the localstorage stash, but it's only loaded on first modal open and then never refreshed?
Nit: add the logo media library ID to the event props and maybe also the prompt used to generate the logo (as mentioned by @ederrengifo )
1950287
to
691c09a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Working nicely!
Fixes #40572
Fixes #40611
Proposed changes:
Other information:
Jetpack product discussion
Slack thread about some limitations: p1734103605310639-slack-C054LN8RNVA
PS with designs: p1HpG7-uzm-p2
Does this pull request change what data or activity we track or use?
Nope
Testing instructions:
type
parameter that should belogo-generator
localStorage.setItem('debug', '*')
in the console to see the above eventsScreenshot