Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publicize: Adjust how the Connections Post Field is initialised #40613

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Publicize: Adjust how the Connections Post Field is initialised #40613

wants to merge 1 commit into from

Conversation

pablinos
Copy link
Contributor

In order to make it compatible with use on WPCOM we need to adjust how the Connections Post Field is initialised. This adds a constructor to handle registering the rest_init hook, and adds the WPCOM specific logic.

Fixes Automattic/jetpack-reach#720

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

We need to check that the behaviour is the same as it is currently.

  • On a site with Publicize set up and at least one active social connection
  • Apply this branch/PR
  • In the block editor for a new post, ensure that the connections are displayed as soon as you open the Jetpack sidebar
  • Toggle one or more of the social connections to disable it, and add a custom message
  • Save the post and reload the editor.
  • Your changes should have been saved.

@pablinos
Publicize: Adjust how the Connections Post Field is initialised
b49bf09 
In order to make it compatible with use on WPCOM we need to adjust how
the Connections Post Field is initialised. This adds a constructor to
handle registering the `rest_init` hook, and adds the WPCOM specific
logic.
@pablinos pablinos requested a review from a team December 13, 2024 20:41
@pablinos pablinos self-assigned this Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/post-connections-field-config branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/post-connections-field-config

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added the [Feature] Publicize Now Jetpack Social, auto-sharing label Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Dec 13, 2024
manzoorwanijk
manzoorwanijk reviewed Dec 16, 2024
View reviewed changes
projects/packages/publicize/src/class-publicize-setup.php
// Adding on a higher priority to make sure we're the first field registered.
// The priority parameter can be removed once we deprecate WPCOM_REST_API_V2_Post_Publicize_Connections_Field
add_action( 'rest_api_init', array( new Connections_Post_Field(), 'register_fields' ), 5 );
new Connections_Post_Field();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this be initialized on Simple sites?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the on_jetpack_feature_publicize_enabled method here is called on WPCOM. We need an unconditional initialization for WPCOM, the way we do for assets.

Probably, we should have a method named unconditional_initialization inside Publicize_Setup class to add all that logic there and also more that assets initialization logic into that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we would need to adjust the loading of it on WPCOM too

@manzoorwanijk
Copy link
Member

We can now revisit this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manzoorwanijk manzoorwanijk manzoorwanijk left review comments

Assignees

@pablinos pablinos

Labels
[Feature] Publicize Now Jetpack Social, auto-sharing [Package] Publicize [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Needs Team Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablinos @manzoorwanijk