My Jetpack: Add a Protect 'needs-attention' status when Threats are detected.

[elliottprogrammer]

This PR adds a 'needs-attention' status to the Protect product card in My Jetpack when Protect threats are detected.
The Primary CTA changes to "Fix threats".
The 'needs-attention' status itself is actually hidden in the sense that the status still remains as "Active", however the product card border will either be yellow or red

With Threats	With Critical Threats

Fixes https://github.com/Automattic/jetpack-roadmap/issues/1939

Proposed changes:

• I split the needs_attention status into 2 separate statuses (needs-attention__warning & needs-attention__error)
• When Protect detects threats, the protect card has yellow border (needs-attention__warning), if there are Critical threats, Protect has a red border (needs-attention__error).
• If threats are detected, the Protect CTA is "Fix threats".

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Project Thread: pbNhbs-bJN-p2
Design post: p1HpG7-umC-p2

Does this pull request change what data or activity we track or use?

Testing instructions:

• Install/activate Jetpack Protect with a Scan upgrade
• Using the Scan Helper in the Jetpack Debug Helper/Tools plugin, select the first EIACAR Threats selection to Add five EICAR threats to the site (one for every severity).
• Run a scan to detect them
• Proceed to the My Jetpack section, scroll down to the Protect product card.
• Verify the Protect product card has a red border, the CTA is "Fix threats" and the status appears as "Active".
• Now, using the Scan Helper in the Jetpack Debug Helper/Tools plugin again, remove the first EIACAR Threats selection and add a different threat (like maybe a vulnerable plugin threat).
• Now verify the Protect product card has a yellow border, the CTA is "Fix threats" and the status appears as "Active".

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/protect-fix-threats-status branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack add/protect-fix-threats-status
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

[robertsreberski]

I have added one commit to fix minification issue with i18n. The code tests well after that!

I left some remarks, and the phan error should be addressed. Hope that will help move things further.

[robertsreberski]

I ask to understand more: are there no cases we need to actually display "Needs attention" in Protect card?

[robertsreberski]

If so, I could make use of some comment here, cause it's a bit difficult to understand from the context.

[elliottprogrammer]

I ask to understand more: are there no cases we need to actually display "Needs attention" in Protect card?

As I understand it, for the Protect card, even when it has a NEEDS_ATTENTION__{WARNING | ERROR} status (which means threats have been detected), we still want to show the card status as 'Active' (per the designs: v1IWiVmOAvI8yT8CCa4b1I-fi-4398_9423).
I believe this is to portray to the user that Protect is still operating correctly/normally as it should (however threats were detected).
I left a comment in the code (as you suggested) to explain there also.

[elliottprogrammer]

I left some remarks, and the phan error should be addressed. Hope that will help move things further.

@robertsreberski, thanks very much for the review! Much appreciated! 🙌
I've addressed all feedback & suggestions. Also the Phan error.
I believe everything should be good now. Let me know what you think! 🙂