-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack AI: show current featured image on modal #40631
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
9d84ea9
to
8901817
Compare
const featuredMediaId = select( editorStore ).getEditedPostAttribute( 'featured_media' ); | ||
const editorStoreSelect = select( editorStore ); | ||
const featuredMediaURL = editorStoreSelect.getEditedPostAttribute( | ||
'jetpack_featured_media_url' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using jetpack_featured_media_url
to decide is a bit more of a nuance (I think). The post attribute is only set on saving, not immediate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jetpack_featured_media_url
is added on save as a backend API field hook. It should always respond to the current media ID (featured_media
attribute). If we add this as a param to rely on I think we'll be introducing yet another point where things can go out of sync or be in a "dirty" state. I'd stick to just considering featured_media
attribute.
e0f8a55
to
c068595
Compare
…(s), adapt pointer/current refs/states
…elector/store types, fix linter issues with types as well
This reverts commit 7e23832.
…age on first open
… to try and get the value
…ring the generation process
… Also, change how disabling feedback is evaluated
c068595
to
42cfa58
Compare
Proposed changes:
When a featured image is already set, the Featured Image generator modal shows empty on open.
With this change, if a featured image is set, we load it on the modal for visibility.
Other information:
Jetpack product discussion
p1733840898030829-slack-C054LN8RNVA
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Open the editor with a new post. Click on Sidebar's "Set featured image" and select "Generate with AI".