Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack AI: show current featured image on modal #40631

Open
wants to merge 19 commits into
base: trunk
Choose a base branch
from

Conversation

CGastrell
Copy link
Contributor

Proposed changes:

When a featured image is already set, the Featured Image generator modal shows empty on open.
With this change, if a featured image is set, we load it on the modal for visibility.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1733840898030829-slack-C054LN8RNVA

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Open the editor with a new post. Click on Sidebar's "Set featured image" and select "Generate with AI".

  • opening the featured image generator modal with not context (no post content nor title) should open and do nothing
  • close the modal, add a title or some content on the post and open the modal again, this time an image generation should trigger
  • set the generated image as featured image and close the modal
  • open the modal again, see the current featured image should show on the modal and no generation should be triggered

Copy link
Contributor

github-actions bot commented Dec 16, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the change/jetpack-ai-featured-image-show-current branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack change/jetpack-ai-featured-image-show-current
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Extension] AI Assistant Plugin [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Dec 16, 2024
Copy link
Contributor

github-actions bot commented Dec 16, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for January 7, 2025 (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Dec 16, 2024
@CGastrell CGastrell added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Dec 16, 2024
@CGastrell CGastrell force-pushed the change/jetpack-ai-featured-image-show-current branch 2 times, most recently from 9d84ea9 to 8901817 Compare December 17, 2024 04:19
const featuredMediaId = select( editorStore ).getEditedPostAttribute( 'featured_media' );
const editorStoreSelect = select( editorStore );
const featuredMediaURL = editorStoreSelect.getEditedPostAttribute(
'jetpack_featured_media_url'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using jetpack_featured_media_url to decide is a bit more of a nuance (I think). The post attribute is only set on saving, not immediate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jetpack_featured_media_url is added on save as a backend API field hook. It should always respond to the current media ID (featured_media attribute). If we add this as a param to rely on I think we'll be introducing yet another point where things can go out of sync or be in a "dirty" state. I'd stick to just considering featured_media attribute.

@CGastrell CGastrell force-pushed the change/jetpack-ai-featured-image-show-current branch 2 times, most recently from e0f8a55 to c068595 Compare December 20, 2024 20:13
@CGastrell CGastrell force-pushed the change/jetpack-ai-featured-image-show-current branch from c068595 to 42cfa58 Compare December 20, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Extension] AI Assistant Plugin [Extension] AI Assistant [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] Needs Team Review [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants