-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ThreatsModal: Add bulk support #40692
base: add/components/threats-data-views-modal-integration
Are you sure you want to change the base?
ThreatsModal: Add bulk support #40692
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: Please add missing changelog entries for the following projects: Use the Jetpack CLI tool to generate changelog entries by running the following command: Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Protect plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Description
Update the original
ThreatModal
integration (proposed here) to add support for handling bulk threats.Note: This addresses adding a modal for bulk fixer actions to align with that of the internal Protect alternative, however, we should consider a follow up task to add functionality to allow users so select any individual from the bulk list to view the individual threat details, proceed with actions, etc. Drafted up a potential solution for this here: #40720
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
ThreatsModal
andThreatsDataViews
storybooksScanResultsDataViews
instance and displays when trigger theShow auto fixers
actionScreenshots
Single threat:
Multiple threats: