Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social | Add filtering for publicize endpoints #40704

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

manzoorwanijk
Copy link
Member

Proposed changes:

  • Add include filter for publicize/connections endpoint to allow site-wide or shared connections

The implementation is that in order to get site-wide connections, the request should be sent as a blog instead of a user.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • As an admin on a Jetpack site add some social connections.
  • Add some connections as a different author
  • As the author, goto editor
  • Open browser console and enter this
await wp.apiFetch({
    path: '/wpcom/v2/publicize/connections'
})
  • Verify that it returns the connections for the current user by default
  • Now enter this
await wp.apiFetch({
    path: '/wpcom/v2/publicize/connections?include=site-wide'
})
  • Verify that there is a permission error
  • Run the same when logged in as admin
  • Verify that it returns all the connections for the site
  • Mark a connection or two as shared from admin account
  • Run this as author account to get the shared connections as well
await wp.apiFetch({
    path: '/wpcom/v2/publicize/connections?include=shared'
})
  • Verify that the request is successful and includes shared connections
  • Verify that running the request from developer console returns error.

@manzoorwanijk manzoorwanijk added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Team Review labels Dec 20, 2024
@manzoorwanijk manzoorwanijk requested a review from a team December 20, 2024 13:29
@manzoorwanijk manzoorwanijk self-assigned this Dec 20, 2024
Copy link
Contributor

github-actions bot commented Dec 20, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/filtering-for-publicize-endpoints branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/filtering-for-publicize-endpoints
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added the [Feature] Publicize Now Jetpack Social, auto-sharing label Dec 20, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Publicize Now Jetpack Social, auto-sharing [Package] Publicize [Status] Needs Team Review [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant