-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VideoPress package: update react-dom-router from v5 to v6 #40709
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
This is a PR to test the waters before upgrading Jetpack-the-plugin to v6 (and ultimately everything in the monorepo to v7).
Proposed changes:
Essentially I followed this guide:
https://reactrouter.com/6.28.0/upgrading/v5
There weren't too many things to change, but of note is that
<Prompt>
is no longer supported, so I've commented the one instance out.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
CI happy?
Does a VideoPress plugin clickthrough work as expected?