-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Charts: Fixing package TS build #40761
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
If we are publishing the built asset I think we should change the exports and type defs in package.json - I changed in e2116a9. 🤞 |
Fixes n/a
Proposed changes:
v0.1.0 of the package had broken TS support, making it harder to use in other projects. Adding a build step fixes this issue
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
cd projects/js-packages/charts
pnpm run build:prod
pnpm run storybook