-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack AI: trim title and content before triggering featured image generation #40858
Conversation
…iggering featured image generation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described! 🚀
Proposed changes:
Make sure content and title are not just empty spaces to decide on triggering featured image generation
Other information:
Jetpack product discussion
p8oabR-1Bq-p2#comment-8338
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Open the editor and use post sidebar's "Set featured image" -> "Generate with AI". As title and post are empty, it should not trigger an image generation. Close the modal, add spaces either on title or some paragraph and open the Featured Image modal again. It should still not trigger any generation. Close it again and now add some title to the post. Open the modal once more and see that it has now triggered an image generation based on the title.