Forms: Fix block style variations not appearing in the editor

[talldan]

Fixes #41119

Proposed changes:

Fixes the form block's style variations not appearing in the editor.

The issue seems to be caused by the class names in the stylesheet being the wrong way around. They expect the element with .jetpack-contact-form to be parent of .is-style-outlined, but it's the other way around, .is-style-outlined is set on the block wrapper, and .jetpack-contact-form is an inner element.

I've fixed it by updating the CSS. I expect this needs some thorough testing, as these style may have been dormant for a while.

This could be a more radical fix that does some more restructuring to the CSS and block markup, but I think this is a good change to tread lightly with. Separately it might be worth reconsidering a lot of the CSS for the form block. It should be possible to make the editor styles more closely match the front-end markup and not require so much duplication, but then I don't know much of the history of this block.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Does this pull request change what data or activity we track or use?

No

Testing instructions:

1. Add a contact form block.
2. Ensure the contact form block is selected, and from the block inspector select the 'Styles' tab and choose either the 'Animated' or 'Outlined' block styles
3. Observe that the block style visually updates in the editor to match the frontend. In trunk it doesn't change.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/form-style-variations-in-editor branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack fix/form-style-variations-in-editor
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for none scheduled (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[github-actions]

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

[ramonjd]

Great stuff. Works as described. Here are some gifs for you!

Before

After

[talldan]

After further testing, I spotted an issue with Single & Multiple Choice fields when the Outlined style is applied. Pushed a commit to fix it.

Before - the field is too wide and the checkboxes overflow

After - looks pretty good

[ramonjd]

Kapture.2025-02-06.at.10.39.54.mp4

LGTM