Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove: Start page modal - default to core behaviour. #41479

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

Remove: Start page modal - default to core behaviour. #41479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1718835
remove start page modal
jorgefilipecosta Jan 30, 2025
86ad3f5
changelog
jorgefilipecosta Jan 31, 2025
0fa4390
remove unrequired package
jorgefilipecosta Mar 7, 2025
d2667ee
clean up
jorgefilipecosta Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .pnpmfile.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,7 @@
function fixDeps( pkg ) {
// Deps tend to get outdated due to a slow release cycle.
// So change `^` to `>=` and hope any breaking changes will not really break.
if (
pkg.name === '@automattic/social-previews' ||
pkg.name === '@automattic/page-pattern-modal'
) {
if ( pkg.name === '@automattic/social-previews' ) {
for ( const [ dep, ver ] of Object.entries( pkg.dependencies ) ) {
if ( dep.startsWith( '@wordpress/' ) && ver.startsWith( '^' ) ) {
pkg.dependencies[ dep ] = '>=' + ver.substring( 1 );
Expand Down
50 changes: 1 addition & 49 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions projects/packages/jetpack-mu-wpcom/changelog/remove-start-page-modal
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: removed

Start page pattern modal: Removed start page pattern modal. We will default to core behaviour from now on, which has equivalent functionality.
1 change: 0 additions & 1 deletion projects/packages/jetpack-mu-wpcom/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
"@automattic/jetpack-base-styles": "workspace:*",
"@automattic/jetpack-shared-extension-utils": "workspace:*",
"@automattic/launchpad": "1.1.0",
"@automattic/page-pattern-modal": "1.1.5",
"@automattic/typography": "1.0.0",
"@popperjs/core": "^2.11.8",
"@preact/signals": "1.2.2",
Expand Down
1 change: 0 additions & 1 deletion projects/packages/jetpack-mu-wpcom/src/class-jetpack-mu-wpcom.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,6 @@ public static function load_etk_features() {
require_once __DIR__ . '/features/wpcom-global-styles/index.php';
require_once __DIR__ . '/features/wpcom-legacy-fse/wpcom-legacy-fse.php';
require_once __DIR__ . '/features/wpcom-whats-new/wpcom-whats-new.php';
require_once __DIR__ . '/features/starter-page-templates/class-starter-page-templates.php';
}
}

Expand Down
Loading
Loading