-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter for dataview list #41483
base: update/unowned-section-to-list
Are you sure you want to change the base?
Add filter for dataview list #41483
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
Code Coverage SummaryNo summary data is avilable for parent commit 8e8bcb6, cannot calculate coverage changes. 😴 If that commit is a feature branch rather than a trunk commit, this is expected. Otherwise, you might try re-running the Tests / Publish coverage data job on this PR once the corresponding job on the trunk commit has succeeded. |
9233580
to
bed0e3c
Compare
bed0e3c
to
661cc85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works well. I left a minor comment, but I think it would be good to move where we do the capitalization
|
||
const categoryOptions = categories.map( category => ( { | ||
value: category, | ||
label: category.charAt( 0 ).toUpperCase() + category.slice( 1 ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say we could use text-transform: uppercase
wherever this is being displayed lol
Proposed changes:
Other information:
Jetpack product discussion
P2: pghfsA-2S-p2
Does this pull request change what data or activity we track or use?
No
Testing instructions:
(Image is if CRM is active, Manage disappears)