Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social: Handle connections with the must_reauth status #41494

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

pablinos
Copy link
Contributor

@pablinos pablinos commented Feb 1, 2025

LinkedIn connections need to be reauthenticated every year. Currently that is every 60 days, but as we release the change to use the refresh token, it will mean that all LinkedIn connections will be marked as needing to be reauthenticated.

The connections will still be able to be used, but the UI will now say that they need reconnecting and follow a similar process to the broken connections.

Fixes Automattic/jetpack-reach#738

Proposed changes:

Adjust the connections management components so that connections are displayed in a 'reauth' state.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Create a LinkedIn connection on a test site
  • Sandbox the API and apply 166999-ghe-Automattic/wpcom
  • Load the editor and open the Jetpack sidebar
  • You should see a message about a connection needing attention
  • Open the connections management modal
  • The LinkedIn connection will have a message about needing to be reconnected and the option to reconnect it, like broken connection
  • Reconnect the LinkedIn connection and it should return to the green Connected state

LinkedIn connections need to be reauthenticated every year. Currently
that is every 60 days, but as we release the change to use the refresh
token, it will mean that all LinkedIn connections will be marked as
needing to be reauthenticated.

The connections will still be able to be used, but the UI will now say
that they need reconnecting and follow a similar process to the broken
connections.
Copy link
Contributor

github-actions bot commented Feb 1, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/broken-connection-notifications branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/broken-connection-notifications
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Feb 1, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Feb 1, 2025
Copy link
Contributor

github-actions bot commented Feb 1, 2025

Code Coverage Summary

Coverage changed in 5 files.

File Coverage Δ% Δ Uncovered
projects/js-packages/publicize-components/src/components/services/service-status.tsx 6/10 (60.00%) -25.71% 3 💔
projects/js-packages/publicize-components/src/components/connection-management/connection-status.tsx 2/4 (50.00%) -16.67% 1 💔
projects/js-packages/publicize-components/src/components/connection/index.js 10/14 (71.43%) -5.04% 0 💚
projects/js-packages/publicize-components/src/components/services/service-item.tsx 14/16 (87.50%) 0.83% 0 💚
projects/js-packages/publicize-components/src/components/form/broken-connections-notice.tsx 0/12 (0.00%) 0.00% -6 💚

Full summary · PHP report · JS report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Publicize Now Jetpack Social, auto-sharing [JS Package] Publicize Components RNA [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant