-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema.prototype.jsonSchema(): convert Mongoose Schema to JSON schema #15184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… schema to JSONSchema re: #11162
hasezoey
approved these changes
Jan 16, 2025
hasezoey
added
the
new feature
This change adds new functionality, like a new method or class
label
Jan 16, 2025
hasezoey
approved these changes
Jan 18, 2025
hasezoey
reviewed
Jan 21, 2025
Comment on lines
+96
to
+98
result.additionalProperties = useBsonType | ||
? { ...embeddedSchemaType.toJSONSchema(options) } | ||
: { ...embeddedSchemaType.toJSONSchema(options) }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should those 2 paths be the exact same?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re: #11162, add a
jsonSchema()
method to schemas that allows creating a JSON schema for use with MongoDB server's$jsonSchema
data validation. Alternatively, it can also produce a JSON schema for validation with normal JSON schema validators, like ajv - MongoDB's JSON schema syntax is slightly different and supports different types.Examples