fix: make navigation block's overlayMenu default never #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leogermani
approved these changes
Jun 1, 2023
|
Awesome - thanks @leogermani! 🙌 |
matticbot
pushed a commit
that referenced
this pull request
Jun 22, 2023
# [1.3.0-alpha.1](v1.2.2...v1.3.0-alpha.1) (2023-06-22) ### Bug Fixes * add bottom space to post title in editor ([#60](#60)) ([ca6c9a1](ca6c9a1)) * correct single post space; add tag styles ([#59](#59)) ([f3645d0](f3645d0)) * correct spacing values ([#46](#46)) ([12cf2b4](12cf2b4)) * hide author, date for pages in search ([#53](#53)) ([52b7a7f](52b7a7f)) * make archive spacing more consistent ([#56](#56)) ([041ec88](041ec88)) * make navigation block's overlayMenu default never ([#58](#58)) ([8fa02a6](8fa02a6)) * make sure wide/full blocks can flow outside of the content ([#66](#66)) ([2e282b7](2e282b7)) * remove IDs from navigation blocks ([#50](#50)) ([1f140be](1f140be)) ### Features * add a clamp to the larger spacing sizes ([#47](#47)) ([d3a01f4](d3a01f4)) * add large image single post variation ([#54](#54)) ([838128a](838128a)) * add search toggle template parts ([#51](#51)) ([ad4e0a7](ad4e0a7)) * change search block's default settings ([#44](#44)) ([1487a69](1487a69)) * update page, homepage templates to remove unneeded elements ([#49](#49)) ([2b888cd](2b888cd)) * update search block styles ([#52](#52)) ([6ed06fb](6ed06fb)) * update search styles ([#61](#61)) ([bf0d776](bf0d776))
|
🎉 This PR is included in version 1.3.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Jul 17, 2023
# [1.3.0](v1.2.2...v1.3.0) (2023-07-17) ### Bug Fixes * add bottom space to post title in editor ([#60](#60)) ([ca6c9a1](ca6c9a1)) * correct single post space; add tag styles ([#59](#59)) ([f3645d0](f3645d0)) * correct spacing values ([#46](#46)) ([12cf2b4](12cf2b4)) * hide author, date for pages in search ([#53](#53)) ([52b7a7f](52b7a7f)) * make archive spacing more consistent ([#56](#56)) ([041ec88](041ec88)) * make navigation block's overlayMenu default never ([#58](#58)) ([8fa02a6](8fa02a6)) * make sure wide/full blocks can flow outside of the content ([#66](#66)) ([2e282b7](2e282b7)) * remove IDs from navigation blocks ([#50](#50)) ([1f140be](1f140be)) ### Features * add a clamp to the larger spacing sizes ([#47](#47)) ([d3a01f4](d3a01f4)) * add large image single post variation ([#54](#54)) ([838128a](838128a)) * add search toggle template parts ([#51](#51)) ([ad4e0a7](ad4e0a7)) * change search block's default settings ([#44](#44)) ([1487a69](1487a69)) * update page, homepage templates to remove unneeded elements ([#49](#49)) ([2b888cd](2b888cd)) * update search block styles ([#52](#52)) ([6ed06fb](6ed06fb)) * update search styles ([#61](#61)) ([bf0d776](bf0d776))
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Similar to #44, this PR changes the default settings for the Navigation block. In this case, it changes the "OverlayMenu" (essentially the mobile hamburger) option to 'never' by default. This matches with how the menu will be used in our template parts for now.
How to test the changes in this Pull Request:
Other information: