Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content-distribution): refactor outgoing post js #188

Merged
merged 18 commits into from
Jan 20, 2025

Conversation

miguelpeixe
Copy link
Member

Refactor the outgoing post JS to use the new ContentDistributionPanel from #181.

Testing

  1. Checkout this branch, draft a new post and publish
  2. Navigate to the 🌐 panel
  3. Select nodes and distribute
  4. Confirm the UI behaves as expected

@miguelpeixe miguelpeixe requested a review from naxoc January 16, 2025 13:03
@miguelpeixe miguelpeixe self-assigned this Jan 16, 2025
@miguelpeixe miguelpeixe requested a review from a team as a code owner January 16, 2025 13:03
Base automatically changed from feat/content-distribution-editor-block to trunk January 20, 2025 10:02
Copy link
Member

@naxoc naxoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests well! 👍

One small thing: It looks like the changes from #193 are being overwritten. Other than that it's good to go.

@miguelpeixe
Copy link
Member Author

Whoops! Fixed in a21e1e9

@miguelpeixe miguelpeixe merged commit cc08edc into trunk Jan 20, 2025
3 of 4 checks passed
@miguelpeixe miguelpeixe deleted the fix/content-distribution-editor-outgoing-post branch January 20, 2025 15:49
Copy link

Hey @miguelpeixe, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

matticbot pushed a commit that referenced this pull request Jan 23, 2025
# [2.5.0-alpha.1](v2.4.0...v2.5.0-alpha.1) (2025-01-23)

### Bug Fixes

* **content-distribution:** block additional UI components ([#197](#197)) ([3f30cdb](3f30cdb))
* **content-distribution:** handling multiple post meta ([#199](#199)) ([c93084d](c93084d))
* **content-distribution:** Improve CSS for blocked editor ([#193](#193)) ([295bdad](295bdad)), closes [#181](#181)
* **content-distribution:** persist site hash ([#186](#186)) ([120b759](120b759))
* **content-distribution:** prevent consecutive dispatches ([#198](#198)) ([2149a62](2149a62))
* **content-distribution:** refactor outgoing post js ([#188](#188)) ([cc08edc](cc08edc))
* **memberships:** remove managed fields on cancel or expire ([#192](#192)) ([67a5cf0](67a5cf0))

### Features

* **content-distribution:** Block the editor for incoming posts ([#181](#181)) ([48b4cae](48b4cae))
* **content-distribution:** confirm dialog for unlinking and relinking posts ([#190](#190)) ([f36bb28](f36bb28))
* **content-distribution:** migrator ([#185](#185)) ([06ec18a](06ec18a))
* **content-distribution:** post status on create ([#189](#189)) ([1ad3e0c](1ad3e0c))
* sync multiple user roles ([#187](#187)) ([9fa833c](9fa833c))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.5.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants