-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle user deletion event on the network #91
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
<?php | ||
/** | ||
* Newspack Hub User Deleted Incoming Event class | ||
* | ||
* @package Newspack | ||
*/ | ||
|
||
namespace Newspack_Network\Incoming_Events; | ||
|
||
use Newspack_Network\Debugger; | ||
use Newspack_Network\Utils\Users as User_Utils; | ||
|
||
/** | ||
* Class to handle the user deletion. | ||
*/ | ||
class User_Deleted extends Abstract_Incoming_Event { | ||
/** | ||
* Processes the event | ||
* | ||
* @return void | ||
*/ | ||
public function post_process_in_hub() { | ||
$this->process_user_deleted(); | ||
} | ||
|
||
/** | ||
* Process event in Node | ||
* | ||
* @return void | ||
*/ | ||
public function process_in_node() { | ||
$this->process_user_deleted(); | ||
} | ||
|
||
/** | ||
* Process user deleted | ||
* | ||
* @return void | ||
*/ | ||
public function process_user_deleted() { | ||
$email = $this->get_email(); | ||
Debugger::log( 'Processing user deletion with email: ' . $email ); | ||
if ( ! $email ) { | ||
return; | ||
} | ||
$user = get_user_by( 'email', $email ); | ||
if ( ! $user ) { | ||
Debugger::log( sprintf( 'User to be deleted not found by email: %s, skipping.', $email ) ); | ||
return; | ||
} | ||
|
||
// Ensure this is a network reader. | ||
$userdata = get_userdata( $user->ID ); | ||
if ( [ NEWSPACK_NETWORK_READER_ROLE ] !== $userdata->roles ) { | ||
Debugger::log( sprintf( 'User %s is not only or not a network reader, skipping deletion.', $email ) ); | ||
return; | ||
} | ||
|
||
/** Make sure `wp_delete_user()` is available. */ | ||
require_once ABSPATH . 'wp-admin/includes/user.php'; | ||
|
||
// Don't broadcast this deletion on the network. | ||
add_filter( 'newspack_network_process_user_deleted', '__return_false' ); | ||
// Delete the user. | ||
$result = \wp_delete_user( $user->ID ); | ||
remove_filter( 'newspack_network_process_user_deleted', '__return_false' ); | ||
|
||
if ( $result ) { | ||
Debugger::log( sprintf( 'User %s deleted.', $email ) ); | ||
} else { | ||
Debugger::log( sprintf( 'User %s could not be deleted.', $email ) ); | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting this results in conflicting messaging in the logs where the account is logged as skipped, but then is logged as deleted:
Since the final log indicates the deletion was successful, I think this is not a blocker.