Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Guest Contributors Create function #3784

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Draft

Feat: Guest Contributors Create function #3784

wants to merge 2 commits into from

Conversation

ronchambers
Copy link
Collaborator

All Submissions:

Changes proposed in this Pull Request:

Closes # .

How to test the changes in this Pull Request:

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

eddiesshop
eddiesshop previously approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@eddiesshop eddiesshop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall. Just some minor concerns. I think these changes might need to be run through PHPCS?

includes/plugins/co-authors-plus/class-guest-contributor-role.php
}

// try a different random suffix on each loop
$suffix = '-' . rand( 11111, 99999 ) . $email_suffix;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wp_rand needs to be used here instead.

includes/plugins/co-authors-plus/class-guest-contributor-role.php
}

// try a different random suffix on each loop
$suffix = '-' . rand( 11111, 99999 );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wp_rand

@github-actions github-actions bot added the [Status] Approved The pull request has been reviewed and is ready to merge label Feb 26, 2025
@ronchambers ronchambers removed the [Status] Approved The pull request has been reviewed and is ready to merge label Feb 27, 2025
@ronchambers ronchambers dismissed eddiesshop’s stale review February 27, 2025 16:30

I removed the approval until we figure out the NMT/NCCM User Helper stuff...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddiesshop eddiesshop eddiesshop left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronchambers @eddiesshop