Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap each javascript into their own function to prevent strict mode from leaking to other scripts #57

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Tug
Copy link

@Tug Tug commented Aug 21, 2020

This PR adds a prefix and suffix to all js scripts concatenated together, so that we don't end up with errors due to scripts starting with "use strict";.

Prefix:

(function(window, document, undefined) {

Suffix:

}).call(this, window, document);

@Tug Tug self-assigned this Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant