Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break up asset groups of over 150 #78

Merged
merged 9 commits into from
Jan 22, 2025
Merged

Conversation

trepmal
Copy link
Contributor

@trepmal trepmal commented Jul 3, 2024

If there are more than 150 files in a single concatenated asset, it returns a 400 with no other error. We can proactively break up these large groups.

$concat_max_files = 150;

if ( 0 == count( $args ) || count( $args ) > $concat_max_files )
concat_http_status_exit( 400 );

concat-utils.php Outdated Show resolved Hide resolved
@rinatkhaziev rinatkhaziev changed the title break up asset groups of over 100 break up asset groups of over 150 Jan 22, 2025
Copy link
Contributor Author

@trepmal trepmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 updates look good in my test environment

@rinatkhaziev rinatkhaziev merged commit 5b5366b into master Jan 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants