Add 2 new tests for recent issues cases #1425
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asturur
changed the title
|
Would you mind fixing the linting issues: https://travis-ci.org/Automattic/node-canvas/jobs/531320266 |
LinusU
reviewed
May 13, 2019
test/public/tests.js
Outdated
| ctx.transform(cos, sin, -sin, cos, x, y); | ||
| } | ||
|
|
||
| var I = 100; |
There was a problem hiding this comment.
Since this is just used on the line below, I would just do for (var i = 0; i < 100; i++)
There was a problem hiding this comment.
yes i just copy pasted the code from the issue, i did not think of improving it.
|
hey thanks, i have been quite busy at work |
Improve gradient test
zbjornson
force-pushed
the
master
branch
2 times, most recently
from
64ed3d8 to
ff0f2ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added correct test for drawImage + clip + shadow
Added failing test for gradient + low opacity
