-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstract Backend
class for screen backends with double buffering support
#1540
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # src/backend/Backend.h
Can this be reviewed and merged? It only abstracts the creation of screen-based drawing backends allowing to be as basis to draw directly on Linux framebuffer of X11 o Windows GDI or macOS Cocoa, there's no conflicts at all. Only thing that maybe would have some concerns are the dynamically created objects at https://github.com/Automattic/node-canvas/pull/1540/files#diff-5c8e889223e6698e689baa171f92bcd9R38-R40, but since they are running in their own short-lived thread they will not create a memory leak. Can somebody confirm it, of tell me what could be a better aproach to explicitly destroy them? |
Code sync'ed with latest |
Can this pull-request be reviewed and merged? :-) |
64ed3d8
to
ff0f2ab
Compare
Thanks for contributing!