Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Podcast Feed Reload] Add tooltip #2735

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

danielebogo
Copy link
Contributor

@danielebogo danielebogo commented Feb 6, 2025

📘 Part of: #2703

This PR adds the tooltip to advise the user of the feed reload functionality.

Light Dark
IMG_0073 IMG_0074

To test

  • Make sure you have the podcastFeedUpdate FF enabled
  • Make sure to enable the tracks logger
    • You can find both under Profile -> Cog icon at top right -> Beta Features
  • Navigate to a podcast detail
  • When the view appears confirm you see the tooltip (like the one in the screenshot above)
  • Confirm you see 🔵 Tracked: podcast_refresh_episode_tooltip_shown
  • Tap the view to dismiss it
  • Confirm you see 🔵 Tracked: podcast_refresh_episode_tooltip_dismissed
  • Navigate back
  • Open a podcast again (same as before or a new one)
  • Confirm the tooltip is not showed again

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo marked this pull request as ready for review February 6, 2025 20:13
@danielebogo danielebogo requested a review from a team as a code owner February 6, 2025 20:13
}
}

struct TipViewStatic: View {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergioEstevao I extracted the body to a new View as I had many problems with the size returned by the geometry proxy. Using a static view and setting this sizingOptions = [.preferredContentSize] seems to work properly each time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant