Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Clip: Add loading and error states #2745

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

SergioEstevao
Copy link
Contributor

| 📘 Part of: #2549 |
|:---:|

Fixes #

This PR introduces a loading and error states to App Clips in order to not show an empty/non-configured clip to users.

For now it just shows a progress bar and then the player or if the episode loading failed an alert saying that an error existed.

Should we consider a small Pocket Casts banner with some text instead?

Loading Error
Simulator Screenshot - iPhone 16 Pro Max - 2025-02-12 at 13 58 49 Simulator Screenshot - iPhone 16 Pro Max - 2025-02-12 at 13 57 59

To test

  • Choose the App Clip target
  • Tap run
  • Check that on launch you see a loading indicator and then followed up by the player interface
  • Stop the app
  • Edit the App Clip scheme
  • Open the Run Section
  • Tap on Argument tabs
  • Remove the app clip invocation argument : c2r28q2u
  • Start the app clip
  • Check if the loading state shows up followed by the error state

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added this to the 7.82 ❄️ milestone Feb 12, 2025
@SergioEstevao SergioEstevao requested a review from a team as a code owner February 12, 2025 14:01
@SergioEstevao SergioEstevao requested review from bjtitus and removed request for a team February 12, 2025 14:01
@dangermattic
Copy link
Collaborator

dangermattic commented Feb 12, 2025

1 Warning
⚠️ This PR is assigned to the milestone 7.82 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@danielebogo danielebogo requested review from danielebogo and removed request for bjtitus February 12, 2025 14:08
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergioEstevao
it works as described. I left one comment only about what we discussed in our sync.
Other than that it's all good

Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@SergioEstevao SergioEstevao merged commit faaef90 into release/7.82 Feb 12, 2025
4 of 6 checks passed
@SergioEstevao SergioEstevao deleted the app_clip/update_error_status branch February 12, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants