Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Clips] Add empty state for App Clip #2809

Open
wants to merge 3 commits into
base: release/7.84
Choose a base branch
from

Conversation

danielebogo
Copy link
Contributor

@danielebogo danielebogo commented Mar 6, 2025

📘 Part of: #2549

This PR replaces the Alert with an empty state for when the App Clip can not handle a URL.

Light Dark
RocketSim_Screenshot_iPhone_16_6 1_2025-03-06_17 19 31 RocketSim_Screenshot_iPhone_16_6 1_2025-03-06_17 19 42

To test

• In Xcode Select the App Clip scheme
• Edit the scheme and the appClipInvocationURLString with https://pca.st/hiddenbrain
• Run the App Clip target
• Confirm you see the placeholder

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo added this to the 7.84 ❄️ milestone Mar 6, 2025
@danielebogo danielebogo requested a review from a team as a code owner March 6, 2025 17:38
@dangermattic
Copy link
Collaborator

dangermattic commented Mar 6, 2025

1 Warning
⚠️ This PR is assigned to the milestone 7.84 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@danielebogo danielebogo linked an issue Mar 6, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project: App Clip
2 participants