Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest Buildkite plugins #3300

Merged
merged 3 commits into from
Mar 6, 2025
Merged

Use latest Buildkite plugins #3300

merged 3 commits into from
Mar 6, 2025

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Mar 3, 2025

Fix

Use latest Buildkite plugins:

  • CI toolkit v5 for better Windows support
  • nvm v0.4.0 for better logs

Test

See green CI for the Windows step in this PR:

image

Note

Looking at the logs made me realize we don't have Node.js modules caching in CI. Tracked in #3301

Release notes

N.A.

@mokagio
Copy link
Contributor Author

mokagio commented Mar 3, 2025

2 out of 2 retries of the Linux build failed because... CI was out of space?

[2025-03-03T05:12:28Z]   • adding autoupdate files for: deb. (Beta feature)  resourceDir=/var/lib/buildkite-agent/builds/ci-default-i-0ed01604171f98913-1/automattic/simplenote-electron/release/linux-unpacked/resources
[2025-03-03T05:12:30Z]   ⨯ cannot execute  cause=exit status 1
[2025-03-03T05:12:30Z]                     errorOut=/var/lib/buildkite-agent/.cache/electron-builder/fpm/fpm-1.9.3-2.3.1-linux-x86_64/lib/ruby/lib/ruby/2.3.0/fileutils.rb:1394:in `copy_stream': No space left on device - sendfile (Errno::ENOSPC)

I'm not sure how the plugin change, which is all about Windows (or is it?), would affect the Linux build?

@mokagio
Copy link
Contributor Author

mokagio commented Mar 5, 2025

The Linux build is failing because of an underlying infra issue (apparently no space left on the default queue... VMs?)

I also tried running this with version 0.3.0 of the nvm plugin, but the result is the same https://buildkite.com/automattic/simplenote-electron/builds/302.

@mokagio mokagio marked this pull request as ready for review March 6, 2025 02:49
@mokagio mokagio enabled auto-merge (squash) March 6, 2025 02:58
@mokagio
Copy link
Contributor Author

mokagio commented Mar 6, 2025

Thanks @iangmaia and @AliSoftware for the nvm plugin v0.5.0 fix! This PR was failing 100% of the times (bad luck getting all filled agents) and now is green in CI 🎉

@mokagio mokagio requested a review from a team March 6, 2025 02:59
@mokagio mokagio merged commit 6664ba8 into trunk Mar 6, 2025
7 checks passed
@mokagio mokagio deleted the mokagio/ci-toolkit-v5 branch March 6, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants