Studio: fix site not found error when add a site #442
Conversation
src/hooks/use-chat-context.tsx
Outdated
| @@ -120,7 +120,9 @@ export const ChatProvider: React.FC< ChatProviderProps > = ( { children } ) => { | |||
| ! initialLoad[ selectedSite.id ] && | |||
| isCurrent && | |||
| ! pluginsList[ selectedSite.id ] && | |||
| ! themesList[ selectedSite.id ] | |||
| ! themesList[ selectedSite.id ] && | |||
| selectedSite.running === true && | |||
There was a problem hiding this comment.
Should we limit this to running sites? If not, the AI chat context won't retrieve the themes and plugins for stopped sites when selecting them. It's true that for the case of the focus listener, we do limit it to sites running. But that's because we only expect running sites to modify the themes/plugins list (discussion).
There was a problem hiding this comment.
I tried removing the condition selectedSite.running === true and, although it works to fetch themes/plugins when selecting already-created sites, it doesn't retrieve properly newly created sites as it's returning empty arrays.
We might need to tweak this logic to ensure we fetch the themes/plugins for the following cases:
- After creating a new site.
- Selecting a site for the first time in a session (i.e. we didn't perform an initial load).
There was a problem hiding this comment.
@fluiddot , I updated the logic. It should be ok now. What do you think? Do you find any cases that this doesn't produce the expected behavior?
There was a problem hiding this comment.
I've directly tested the chat context by asking the assistant Give me the site context and noticed that we are not saving properly the initial state. The themes and plugins seem to be only saved to the state when the app gains focus on a site running.
It's likely that the changes introduced in #272 have disrupted this logic 😞. I'll take a look and provide a fix. In the meantime, we can merge this PR.
Fixes https://github.com/Automattic/dotcom-forge/issues/8624
Proposed Changes
When we add a new site, the following error is thrown
'executeWPCLiInline': Error: Site not found.This PR fixes that.
Testing Instructions
Pre-merge Checklist