Studio: Remove connect site button when already exists a Sync connection #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekn
approved these changes
Dec 20, 2024
wojtekn
deleted the
fix/remove-connect-site-button-for-existing-connections
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Closes https://github.com/Automattic/dotcom-forge/issues/10158
Proposed Changes
This PR removes the
Connectbutton on theSyncscreen when there is a connection already present.Testing Instructions
npm startConnect sitebuttonConnect sitebutton present on theSyncscreenPlease note that this PR does not do any cleanup on the logic for connecting multiple sites to a local site. As per this comment, we will create a separate logic to do this cleanup.
Pre-merge Checklist