New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Studio: Fix spacing between the offline and toggle sidebar icons for RTL languages #759

Merged

katinthehatsite merged 1 commit into trunk from fix/spacing-icons-topbar-rtl

Dec 23, 2024

Contributor

katinthehatsite commented Dec 20, 2024 •

edited

Loading

Related issues

Closes https://github.com/Automattic/dotcom-forge/issues/10167

Proposed Changes

This PR adds spacing between the offline icon and toggle sidebar button in the topbar for rtl languages:

Before

After

Testing Instructions

Pull the changes from this branch
Start Studio with npm start
Switch the app to RTL language e.g. Hebrew
Turn off WiFi to display the offline icon
Observe the spacing between the icons
Switch back to LTR language
Confirm that the spacing looks correct and remains unaffected

Pre-merge Checklist

Have you checked for TypeScript, React or other console errors?


          fix spacing rtl

6a315db

katinthehatsite self-assigned this

katinthehatsite requested a review from a team

December 20, 2024 21:42

katinthehatsite merged commit 3dc4114 into trunk

7 checks passed

katinthehatsite deleted the fix/spacing-icons-topbar-rtl branch

December 23, 2024 15:22

Contributor

ivan-ottinger commented Jan 3, 2025

Great catch, Kat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet