Studio: Add config constants to mu-plugins #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
@katinthehatsite the code change looks clear, and it fixes the issue for such sites. |
wojtekn
approved these changes
Jan 3, 2025
| `<?php | ||
| // Define database constants if not already defined. It fixes the error | ||
| // for imported sites that don't have those defined e.g. WP Cloud and | ||
| // include plugins which try to access those directly e.g. Mailpoet |
There was a problem hiding this comment.
I updated the comment to clearly state what is the purpose of the polyfill.
|
I have reviewed and tested this PR as well and it is working as expected. The mu plugin is getting added and makes sure the missing constants are defined. 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Closes https://github.com/Automattic/dotcom-forge/issues/10148
Proposed Changes
This PR adds polyfill to
mu-pluginsfor database constants in case they are not defined in thewp-config.phpfile when it is being imported. This ensures that the database constants are defined at all times.Testing Instructions
wp-admin/plugins.php?plugin_status=mustuseand confirm that the0-wp-config-constants-polyfill.phpplugin is present thereAlternatively, you can export a Studio site, edit
wp-config.phpfile and remove the constants such asDB_HOSTetc. from that file. You can then attempt to import it and confirm that the import succeeds and that the site starts successfully.Pre-merge Checklist