Run the unit tests for the lowest and latest versions of wp/php

[ingeniumed]

Description

This will update the PHP unit tests workflow to run for the lowest WP/PHP version we support and the latest combo as well. That way at all times we are ensuring our code is working as expected. It also updates some of the actions that are used, to take advantage of the caching/etc improvements.

[alecgeatches]

@ingeniumed The tests have been fixed, would love a review! The main issue here is that some tests were using core blocks directly, and as their attributes changed between WordPress updates it caused direct attribute comparisons to fail. A lot of tests were immune to this problem by registering their own block definitions for tests, like attribute tests:

vip-block-data-api/tests/parser/sources/test-source-html.php

Lines 16 to 22 in 32cda50

	$this->register_block_with_attributes( 'test/paragraph', [
	'content' => [
	'type' => 'string',
	'source' => 'html',
	'selector' => 'p',
	],
	] );

However, REST API and GraphQL tests were using core blocks directly:

vip-block-data-api/tests/rest/test-rest-api.php

Lines 39 to 51 in fc73fc5

	$html = '
	<!-- wp:heading -->
	<h2>Heading 1</h2>
	<!-- /wp:heading -->
	<!-- wp:quote -->
	<blockquote class="wp-block-quote">
	<!-- wp:paragraph -->
	<p>Text in quote</p>
	<!-- /wp:paragraph -->
	<cite>~ Citation, 2023</cite>
	</blockquote>
	<!-- /wp:quote -->

...

vip-block-data-api/tests/rest/test-rest-api.php

Lines 74 to 81 in fc73fc5

	$expected_blocks = [
	[
	'name' => 'core/heading',
	'attributes' => [
	'content' => 'Heading 1',
	'level' => 2,
	],
	],

The problem is that when a block.json attribute is added or changed in a new WordPress version, any test using those blocks and attribute comparison would fail. This was a bit more difficult to fix than the first example test because REST API and GraphQL tests that fire off a request and don't have an easy way to specify a custom registry.

In the changes, I've added a couple of register_global_block_with_attributes() methods (in REST and GraphQL tests respectively) that modify the "real" registry, and then automatically unregister custom blocks after the test completes. This allows us to use mocked core blocks without having a direct dependency on the block's definition in WordPress.

This should fix all test breaks related to core block attribute changes, and make future WordPress testing for this plugin less brittle.

[ingeniumed]

Great improvements to the tests! Just a minor item to tweak before this can be 🚢

[ingeniumed]

Should update this to 6.6 btw