Fix iterator_to_array() error on PHP < 8.2

[alecgeatches]

Description

Fixes #77, which causes this error:

{
  "code": "vip-block-data-api-parser-error",
  "message": "Error parsing post ID 2: iterator_to_array(): Argument #1 ($iterator) must be of type Traversable, array given",
  "data": {
    "status": 500
  }
}

This is caused by a call to iterator_to_array() in parser code:

vip-block-data-api/src/parser/content-parser.php

Lines 299 to 300 in 1593b60

	// WP_Block#inner_blocks can be an array or WP_Block_List (iterable).
	$inner_blocks = iterator_to_array( $block->inner_blocks );

iterator_to_array() will only accept an array in PHP 8.2.

Our plugin supports to PHP 8.0, which means 8.0 and 8.1 will currently show this error for any parsed post.

The changed code now tests for an array and uses it directly if available, which will work on prior PHP versions.

Steps to Test

1. Check out the trunk branch of vip-block-data-api and install on a WordPress installation with PHP version 8.0 or 8.1.

2. Go to a published post's Block Data API URL, e.g.

   https://my.lndo.site/wp-json/vip-block-data-api/v1/posts/1/blocks
   

3. See the iterator error in the response data: Error parsing post ID 1: iterator_to_array(): Argument #1 ($iterator) must be of type Traversable, array given.

4. Change the VIP Block Data API branch to this branch (fix/php-8.1-iterator-error).

5. Reload the wp-json endpoint used in step 2.

6. See that the post renders correctly.

Other Todos

• Figure out why the minimum test matrix (PHP 8/WordPress 6.2) didn't catch this.

  See Fix wp-env to use proper PHP version in test matrix #79.

• Ensure this fix is included in the next update of VIP's integrations.

[chriszarate]

Thanks for the fix

[ingeniumed]

Bumped up the plugin version as well