build: disable promise/no-multiple-resolved #1534
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR disables the
promise/no-multiple-resolved
rule because it causes major slowdown for the Lint job.It took 5 minutes(!) to lint
src/lib/site-import/status.ts
, and the slowest rule waspromise/no-multiple-resolved
.This is most likely related to another rule we suppress:
The function is too complex for
eslint-plugin-promise
to analyze it (or maybe its analysis algorithm is inefficient).Unfortunately,
/* eslint-disable promise/no-multiple-resolved */
does not turn off the rule; it just disables all diagnostics from that rule.Steps to Test
CI should pass.