Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CANTINA-957: Dev-env: Make message after update more clear #1536

Merged
merged 2 commits into from
Oct 27, 2023
Merged

CANTINA-957: Dev-env: Make message after update more clear #1536

merged 2 commits into from
Oct 27, 2023

Conversation

rebeccahum
Copy link
Contributor

Description

This messaging is to clarify and to prevent users from attempting vip dev-env restart since that command doesn't exist.

✓ environment updated. Please start environment again for changes to take effect: vip dev env --slug es-site start

Steps to Test

  1. npm run build
  2. ./dist/bin/vip-dev-env-update.js --slug es-site
  3. See message match description

@rebeccahum rebeccahum marked this pull request as ready for review October 27, 2023 22:18
@rebeccahum rebeccahum requested a review from a team October 27, 2023 22:18
@rebeccahum rebeccahum merged commit 7775557 into trunk Oct 27, 2023
9 checks passed
@rebeccahum rebeccahum deleted the dev-env-update-msg branch October 27, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WPprodigy WPprodigy WPprodigy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rebeccahum @WPprodigy