Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vip dev-env purge command logic #1537

Merged
merged 9 commits into from
Nov 22, 2023
Merged

Add vip dev-env purge command logic #1537

merged 9 commits into from
Nov 22, 2023

Conversation

Michelleeby
Copy link
Contributor

Description

Hello 👋🏼 here is an example of how we might add a purge command to VIP CLI dev-env. It leverages getAllEnvironmentNames() and loops through and awaits destroyEnvironment on each name listed.

Steps to Test

This will need to be plugged into typical testing workflows. I did npm link and also node --inspect locally and it successfully destroyed all local dev-env environments.

@sjinks sjinks force-pushed the trunk branch 2 times, most recently from ce8ac7d to 50cb74a Compare November 7, 2023 08:40
@rebeccahum rebeccahum force-pushed the feature/devenv-purge-cmd branch 2 times, most recently from 18a1a8e to 44493f9 Compare November 22, 2023 00:05
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rebeccahum rebeccahum force-pushed the feature/devenv-purge-cmd branch 4 times, most recently from 883e94b to f8643a7 Compare November 22, 2023 15:59
Michelleeby and others added 5 commits November 22, 2023 14:30
@Michelleeby @rebeccahum
Add vip dev-env purge command logic
4ededcc
@Michelleeby @rebeccahum
Fix most linting errors w/ npm lint:fix
9a5e32e 
The linting errors due to spaces were auto fixed nicely. I think the errors with the await statements might need more thought. I frankenstien'd `vip-dev-env-list` with `vip-dev-env-delete`. My rationale was to send the delete command, wait for its success, then send the next one. The linter doesn't like this loop though.
@Michelleeby @rebeccahum
Silence no-await-in-loop lint warnings, for now
b2bbf4f
@Michelleeby @rebeccahum
Fix linting errors
c0a3e77
@rebeccahum
Add confirmation prompt and existence of environments
3698a7f
@rebeccahum rebeccahum force-pushed the feature/devenv-purge-cmd branch from f8643a7 to 3698a7f Compare November 22, 2023 21:30
@rebeccahum rebeccahum marked this pull request as ready for review November 22, 2023 21:34
@rebeccahum rebeccahum force-pushed the feature/devenv-purge-cmd branch 3 times, most recently from f478b49 to 8d62e2b Compare November 22, 2023 21:57
@rebeccahum rebeccahum force-pushed the feature/devenv-purge-cmd branch from 9ee5a1c to ef8eb73 Compare November 22, 2023 22:09
@rebeccahum rebeccahum force-pushed the feature/devenv-purge-cmd branch from 2266e34 to bc188bb Compare November 22, 2023 22:17
@rebeccahum rebeccahum force-pushed the feature/devenv-purge-cmd branch from 515b0be to 0e8837a Compare November 22, 2023 22:19
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rebeccahum rebeccahum merged commit 296b129 into trunk Nov 22, 2023
15 checks passed
@rebeccahum rebeccahum deleted the feature/devenv-purge-cmd branch November 22, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjinks sjinks sjinks approved these changes

Assignees
No one assigned
Labels
[Status] Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Michelleeby @sjinks @rebeccahum