Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): replace cli-table with cli-table3 #1550

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

sjinks
Copy link
Member

@sjinks sjinks commented Nov 7, 2023

Description

cli-table is abandoned and no longer maintained. cli-table3 is the most current replacement.

cli-table is the last dependency npm complains about:

npm WARN skipping integrity check for git dependency ssh://[email protected]/automattic/cli-table.git

If you find that very commit, Automattic/cli-table@7b14232, GitHub will complain that it does not belong to any branch on this repository:

Screenshot_20231107_143818

That does not look nice. cli-table3 seems to be a safer solution.

Among other things, our dependencies use cli-table3 as well; by switching to cli-table3, we remove at least one dependency.

Steps to Test

Run something like vip config software get before and after and observer that the output look the same.

@sjinks sjinks self-assigned this Nov 7, 2023
Copy link
Contributor

@abdullah-kasim abdullah-kasim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sjinks sjinks merged commit 93c53eb into trunk Nov 8, 2023
10 checks passed
@sjinks sjinks deleted the replace/cli-table branch November 8, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants