-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating ESLint config #1577
Merged
Merged
Updating ESLint config #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gudmdharalds
commented
Nov 21, 2023
@@ -2,3 +2,5 @@ | |||
/__fixtures__/ | |||
/dist/ | |||
/flow-typed/ | |||
/npm-shrinkwrap.json | |||
/CONTRIBUTING.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CONTRIBUTING.md file is here temporarily, this will be removed in #1559. This is to avoid conflict between those two PRs.
20 tasks
sjinks
reviewed
Nov 21, 2023
sjinks
reviewed
Nov 21, 2023
sjinks
reviewed
Nov 21, 2023
sjinks
reviewed
Nov 21, 2023
Co-authored-by: Volodymyr Kolesnykov <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds
.eslintrc.js
to the project and removes.eslintrc.json
. With this change, the project uses the pattern recommened in Automattic/eslint-config-wpvip.The pull request also updates formatting of a number of files that had incorrect formatting and adds a
format:check
test.Steps to Test
Ensure all tests run successfully.