Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ESLint config #1577

Merged
merged 13 commits into from
Nov 22, 2023
Merged

Updating ESLint config #1577

merged 13 commits into from
Nov 22, 2023

Conversation

gudmdharalds
Copy link
Contributor

Description

This pull request adds .eslintrc.js to the project and removes .eslintrc.json. With this change, the project uses the pattern recommened in Automattic/eslint-config-wpvip.

The pull request also updates formatting of a number of files that had incorrect formatting and adds a format:check test.

Steps to Test

Ensure all tests run successfully.

@gudmdharalds gudmdharalds added the [Type] Enhancement New feature or request label Nov 21, 2023
@gudmdharalds gudmdharalds self-assigned this Nov 21, 2023
@gudmdharalds gudmdharalds requested a review from sjinks November 21, 2023 11:33
@@ -2,3 +2,5 @@
/__fixtures__/
/dist/
/flow-typed/
/npm-shrinkwrap.json
/CONTRIBUTING.md
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CONTRIBUTING.md file is here temporarily, this will be removed in #1559. This is to avoid conflict between those two PRs.

.eslintrc.js Outdated Show resolved Hide resolved
.prettierignore Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gudmdharalds gudmdharalds merged commit dd0b0fc into trunk Nov 22, 2023
14 checks passed
@gudmdharalds gudmdharalds deleted the update/linting-rules-2023 branch November 22, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants