Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev-env: Remove 8.0 & 7.4 from available PHP versions #1622

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Dev-env: Remove 8.0 & 7.4 from available PHP versions #1622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6601d9a
Dev-env: Remove 8.0 & 7.4 from available PHP versions
rebeccahum Dec 19, 2023
5869f3c
Update label about PHP 8.3
rebeccahum Dec 19, 2023
d212eeb
Update tests
rebeccahum Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions __tests__/devenv-e2e/001-create.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ describe( 'vip dev-env create', () => {
it( 'should use sane defaults', async () => {
const slug = getProjectSlug();
const expectedMultisite = false;
const expectedPhpVersion = '8.0';
const expectedPhpVersion = '8.2';
const expectedElasticsearch = false;
const expectedPhpMyAdmin = false;
const expectedXDebug = false;
Expand Down Expand Up @@ -109,7 +109,7 @@ describe( 'vip dev-env create', () => {
const slug = getProjectSlug();
const expectedTitle = 'Test';
const expectedMultisite = true;
const expectedPhpVersion = '8.0';
const expectedPhpVersion = '8.2';
const expectedWordPressVersion = '6.1';
const expectedElasticsearch = true;
const expectedPhpMyAdmin = true;
Expand Down
2 changes: 1 addition & 1 deletion __tests__/devenv-e2e/011-configuration-file.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ describe( 'vip dev-env configuration file', () => {
const expectedSlug = getProjectSlug();
const expectedTitle = 'Test';
const expectedMultisite = true;
const expectedPhpVersion = '8.0';
const expectedPhpVersion = '8.2';
const expectedWordPressVersion = '6.1';
const expectedElasticsearch = true;
const expectedPhpMyAdmin = true;
Expand Down
2 changes: 0 additions & 2 deletions __tests__/lib/dev-environment/dev-environment-cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,8 +584,6 @@ describe( 'lib/dev-environment/dev-environment-cli', () => {

describe( 'resolvePhpVersion', () => {
it.each( [
[ '7.4', DEV_ENVIRONMENT_PHP_VERSIONS[ '7.4' ].image ],
[ '8.0', DEV_ENVIRONMENT_PHP_VERSIONS[ '8.0' ].image ],
[ '8.1', DEV_ENVIRONMENT_PHP_VERSIONS[ '8.1' ].image ],
[ '8.2', DEV_ENVIRONMENT_PHP_VERSIONS[ '8.2' ].image ],
[ '8.3', DEV_ENVIRONMENT_PHP_VERSIONS[ '8.3' ].image ],
Expand Down
10 changes: 1 addition & 9 deletions src/lib/constants/dev-environment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,7 @@ export const DEV_ENVIRONMENT_PHP_VERSIONS: Record< string, PhpImage > = {
8.1: { image: 'ghcr.io/automattic/vip-container-images/php-fpm:8.1', label: '8.1' },
8.3: {
image: 'ghcr.io/automattic/vip-container-images/php-fpm:8.3',
label: '8.3 (experimental, not supported)',
},
'8.0': {
image: 'ghcr.io/automattic/vip-container-images/php-fpm:8.0',
label: '8.0 (EOL soon)',
},
7.4: {
image: 'ghcr.io/automattic/vip-container-images/php-fpm:7.4',
label: '7.4 (EOL; not supported)',
label: '8.3',
},
} as const;

Expand Down
Loading