-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gracefully fail when directory is not detected #1947
Merged
ariskataoka
merged 13 commits into
trunk
from
fix/import-validate-files-not-directory-error
Jul 29, 2024
Merged
Gracefully fail when directory is not detected #1947
ariskataoka
merged 13 commits into
trunk
from
fix/import-validate-files-not-directory-error
Jul 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
ariskataoka
force-pushed
the
fix/import-validate-files-not-directory-error
branch
2 times, most recently
from
July 18, 2024 12:06
0106e38
to
e5f3219
Compare
ariskataoka
force-pushed
the
fix/import-validate-files-not-directory-error
branch
from
July 18, 2024 13:40
d9efdfb
to
8cf91ac
Compare
ariskataoka
force-pushed
the
fix/import-validate-files-not-directory-error
branch
from
July 19, 2024 02:44
8bb92bb
to
9abe4b4
Compare
ariskataoka
force-pushed
the
fix/import-validate-files-not-directory-error
branch
from
July 19, 2024 07:19
085662f
to
0031a35
Compare
ariskataoka
force-pushed
the
fix/import-validate-files-not-directory-error
branch
from
July 23, 2024 01:26
07a863b
to
0d8522d
Compare
t-wright
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sjinks
approved these changes
Jul 24, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a user attempts to validate a non-valid folder using the vip import validate-files command, vip-cli fails ungracefully. This PR includes an error message for that scenario and also adds some unit tests for the vip import validate-files command.
Issue pointed here.
Before:
After:
Pull request checklist
New release checklist
Steps to Test
Outline the steps to test and verify the PR here.
Example:
npm run build
node ./dist/bin/vip-import-validate-files.js any.zip