Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB8-11630: Add confirmation for production env vars setting/deleting #1985

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

rebeccahum
Copy link
Contributor

@rebeccahum rebeccahum commented Aug 7, 2024

Description

Adds a confirmation prompt when setting or deleting an env vars on production environments:

╰─$ vip @5190.production config envvar set EXAMPLE_ENV_VAR                                                                                                                            130 ↵
? Are you sure you want to set the environment variable EXAMPLE_ENV_VAR on PRODUCTION for site rebecca-testing-2? (y/N) › false
╰─$ vip @5190.production config envvar delete EXAMPLE_ENV_VAR
? Are you sure you want to delete the environment variable EXAMPLE_ENV_VAR on PRODUCTION for site rebecca-testing-2? (y/N) › false

Pull request checklist

New release checklist

Steps to Test

Outline the steps to test and verify the PR here.

Example:

  1. Check out PR.
  2. Run npm run build
  3. Run vip @5190.production config envvar set EXAMPLE_ENV_VAR and expect confirmation prompt
  4. Run the previous step now with --skip-confirmation and expect no confirmation prompt

Copy link
Contributor

github-actions bot commented Aug 7, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@rebeccahum rebeccahum changed the title BB8-11630: Add confirmation for production env vars setting BB8-11630: Add confirmation for production env vars setting/deleting Aug 7, 2024
Copy link

sonarqubecloud bot commented Aug 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
94.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@rebeccahum rebeccahum requested a review from sjinks August 7, 2024 20:54
@rebeccahum rebeccahum marked this pull request as ready for review August 7, 2024 20:54
@rebeccahum rebeccahum merged commit 490ae44 into trunk Aug 7, 2024
15 of 16 checks passed
@rebeccahum rebeccahum deleted the BB8-11630 branch August 7, 2024 21:03
@rebeccahum rebeccahum restored the BB8-11630 branch August 7, 2024 23:04
@rebeccahum rebeccahum deleted the BB8-11630 branch August 7, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants