fix(dev-env): detection of URLs to replace for multisites #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
sjinks
commented
Nov 1, 2024
sjinks
commented
Nov 1, 2024
sjinks
commented
Nov 6, 2024
Comment on lines
+50
to
+55
| try { | ||
| new URL( url ); | ||
| return url; | ||
| } catch { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
Node 18.17.0 has URL.canParse(); hopefully, we can use it instead of this code someday.
rinatkhaziev
reviewed
Nov 7, 2024
| : this.landoDomain; | ||
|
|
||
| queries.push( | ||
| `UPDATE wp_blogs SET domain = '${ newDomain }' WHERE blog_id = ${ Number( site.blogId ) };` |
There was a problem hiding this comment.
custom prefixes is what gives me a pause here.
|
rinatkhaziev
approved these changes
Nov 8, 2024
luiztiago
added a commit
that referenced
this pull request
Nov 13, 2024
* trunk: Revert "New package release: v3.9.0" chore: bump package version to v3.9.0 Add comment explaining the reason why the limit default value is set manually Remove setImmediate Validate logs limit argument Update socket error handler build(deps): bump uuid from 11.0.2 to 11.0.3 build(deps-dev): bump nock from 13.5.5 to 13.5.6 fix(dev-env): detection of URLs to replace for multisites (#2081)
yolih
pushed a commit
that referenced
this pull request
Nov 18, 2024
* fix(dev-env): detection of URLs to replace for multisites * fix: replacement takes paths into consideration * refactor: simplify `replaceDomain()` * fix: update `wp_blogs` * Fix test cases - we don't have id's anymore --------- Co-authored-by: Rinat Khaziev <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the generation of a map of domains to replace for a multisite environment.
Previously, if a site URL contained a path (e.g.,
https://domain.com/path), such an URL would be replaced withslug.vipdev.sitebecause the system compareddomain.com/pathtodomain.comand ignored it because the strings are not equal.This PR fixes the procedure by comparing domains instead.
Pull request checklist
New release checklist
Steps to Test
See the ticket.